[NEW] REST endpoint to forward livechat rooms (RocketChat#13308)

* Add new rest endpoint allowing agents/managers to forward livechat rooms.
Montel · Feb 13, 2019 · fc70afe · fc70afe
1 parent 71f6eb4
commit fc70afe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/rocketchat-livechat/server/api/v1/room.js b/packages/rocketchat-livechat/server/api/v1/room.js
@@ -153,3 +153,9 @@ RocketChat.API.v1.addRoute('livechat/room.survey', {
 		}
 	},
 });
+
+RocketChat.API.v1.addRoute('livechat/room.forward', { authRequired: true }, {
+	post() {
+		RocketChat.API.v1.success(Meteor.runAsUser(this.userId, () => Meteor.call('livechat:transfer', this.bodyParams)));
+	},
+});
diff --git a/packages/rocketchat-livechat/server/methods/transfer.js b/packages/rocketchat-livechat/server/methods/transfer.js
@@ -16,14 +16,17 @@ Meteor.methods({
 		});
 
 		const room = RocketChat.models.Rooms.findOneById(transferData.roomId);
-
-		const guest = LivechatVisitors.findOneById(room.v._id);
+		if (!room) {
+			throw new Meteor.Error('error-invalid-room', 'Invalid room', { method: 'livechat:transfer' });
+		}
 
 		const subscription = RocketChat.models.Subscriptions.findOneByRoomIdAndUserId(room._id, Meteor.userId(), { fields: { _id: 1 } });
 		if (!subscription && !RocketChat.authz.hasRole(Meteor.userId(), 'livechat-manager')) {
 			throw new Meteor.Error('error-not-authorized', 'Not authorized', { method: 'livechat:transfer' });
 		}
 
+		const guest = LivechatVisitors.findOneById(room.v && room.v._id);
+
 		return RocketChat.Livechat.transfer(room, guest, transferData);
 	},
 });