Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when trying to dismiss already dismissed review #155

Closed
ui-valts-mazurs opened this issue Oct 28, 2020 · 5 comments · Fixed by #161
Closed

Error when trying to dismiss already dismissed review #155

ui-valts-mazurs opened this issue Oct 28, 2020 · 5 comments · Fixed by #161
Assignees
@MorrisonCole
Labels
bug Something isn't working

Comments

@ui-valts-mazurs
Copy link
Contributor

GitHub API call ends with an error when trying to dismiss a review: Can not dismiss a dismissed pull request review. It happens when the action is run for already corrected title.
Seems like dismissReview should filter out reviews in state: DISMISSED.
@MorrisonCole
Copy link
Owner

Hey @ui-valts-mazurs, thanks for reporting that!

Sorry had a crazy two weeks so have been a little slow on this - makes sense and planning to fix this up over the weekend.

@MorrisonCole MorrisonCole self-assigned this Nov 7, 2020
@MorrisonCole MorrisonCole added the bug Something isn't working label Nov 7, 2020
@amclay
Copy link

amclay commented Nov 11, 2020

We are also running into this bug, I think possibly when re-running the action when the 1st run hasn't completed

@MorrisonCole
Copy link
Owner

Gotcha - sorry for the delay folks! Still planning to do this shortly 🙏

@ui-valts-mazurs
Copy link
Contributor Author

ui-valts-mazurs commented Nov 13, 2020 •
edited
Loading

FYI: there is an error "Can not dismiss a commented pull request review" when the GitHub action was run multiple times for an incorrect title.

Edit: this happens when on-failed-regex-request-changes: false, the review is in state COMMENTED. Apparently it is allowed to dismiss only reviews in state CHANGES_REQUESTED

@ui-valts-mazurs ui-valts-mazurs mentioned this issue Nov 16, 2020
Merged
@MorrisonCole
Copy link
Owner

MorrisonCole commented Nov 17, 2020 •
edited
Loading

Hey @ui-valts-mazurs, @amclay (+ any other watchers). So sorry for my slowness on this one, had a busy time recently and this project became more popular than I expected 😅🐌

Thanks to @ui-valts-mazurs this has been fixed and released in v1.4.2 ❤️. I tested it out on a PR here and all seems to be good. Going forward I'll probably be adding some tests and better contribution documentation - thanks for bearing with me!

vlajos added a commit to corda/corda that referenced this issue Jan 6, 2022
@vlajos
ENT-6370 upgrade morrisoncole/pr-lint-action to bypass this: Morrison…
3586b23 
…Cole/pr-lint-action#155
yift-r3 added a commit to corda/corda-api that referenced this issue Feb 23, 2022
@yift-r3
Use version 1.4.2 (see MorrisonCole/pr-lint-action#155)
47327c3
wzur-r3 added a commit to corda/corda-api that referenced this issue Feb 23, 2022
@wzur-r3
Update pr-lint-action to a new version
f2a4403 
see MorrisonCole/pr-lint-action#155
@wzur-r3 wzur-r3 mentioned this issue Feb 23, 2022
Merged
wzur-r3 added a commit to corda/corda-api that referenced this issue Feb 23, 2022
@wzur-r3
Update pr-lint-action to a new version (#262)
d7705d6 
see MorrisonCole/pr-lint-action#155
@gregfurman gregfurman mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MorrisonCole MorrisonCole

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dismiss only reviews in status: CHANGES_REQUESTED ui-valts-mazurs/pr-lint-action
3 participants
@MorrisonCole @amclay @ui-valts-mazurs