Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supplemental damage buff + Add Covenant skills + Limit Hollowsky ( 1 per grid) #233

Merged
merged 61 commits into from
Jun 15, 2019
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
a06a69e
Add Covenant skills - limit Hollowsky per combonation - add supplemen…
happypurpleduck Jun 5, 2019
5aa62d5
Add skillDetails Description in armlist
happypurpleduck Jun 6, 2019
29b8eb9
add/correct translations
happypurpleduck Jun 6, 2019
b6943c2
add/correct translations
happypurpleduck Jun 6, 2019
63d8df5
Merge branch 'master' into master
happypurpleduck Jun 6, 2019
40d2ae1
Add Supplemental Damage Calculation to (enmity) Graph
happypurpleduck Jun 6, 2019
8542bd3
Merge branch 'master' of https://github.com/h-yasha/motocal
happypurpleduck Jun 6, 2019
2918279
Add Supplemental Damage Calculation to (enmity) Graph
happypurpleduck Jun 6, 2019
62fbafb
correct impervious HP threshold
happypurpleduck Jun 6, 2019
3f0b8e9
fix indentation
happypurpleduck Jun 6, 2019
4c500a8
Fix Translation
happypurpleduck Jun 6, 2019
8c5df9d
Merge branch 'master' of https://github.com/h-yasha/motocal
happypurpleduck Jun 6, 2019
05a3bdb
Fix supplemental in enmity graph and minor changes
happypurpleduck Jun 6, 2019
d6ce45e
Merge branch 'master' into master
happypurpleduck Jun 6, 2019
0a747ab
Merge branch 'master' into master
happypurpleduck Jun 6, 2019
9a48814
minor cleanup
happypurpleduck Jun 6, 2019
70b70b9
a woopsie
happypurpleduck Jun 6, 2019
9cc11ff
declare var expectedCycleDamagePerTurn outside of if-block
happypurpleduck Jun 6, 2019
7cb5124
Merge branch 'master' into master
happypurpleduck Jun 7, 2019
ff758dd
update supplemental logic
happypurpleduck Jun 7, 2019
ad33efe
Merge branch 'master' into master
happypurpleduck Jun 7, 2019
3329e84
Merge branch 'master' into master
happypurpleduck Jun 7, 2019
164c283
Fixes.
happypurpleduck Jun 8, 2019
3958c9e
minor changes
happypurpleduck Jun 8, 2019
ddf8ae0
fix indent
happypurpleduck Jun 8, 2019
b8c7d8b
Add new UI element in template
happypurpleduck Jun 8, 2019
a51e151
Merge branch 'master' of https://github.com/h-yasha/motocal
happypurpleduck Jun 8, 2019
0d8c286
Add Hallessena Supabi + 'impactful' Logic Update
happypurpleduck Jun 8, 2019
097bb9a
a large clean up + major fixes
happypurpleduck Jun 8, 2019
4a829c4
Update charaData w/ Hallessena Supabi
happypurpleduck Jun 8, 2019
3dad067
update logic
happypurpleduck Jun 9, 2019
6b9505c
typo
happypurpleduck Jun 9, 2019
635809f
Fix supplemental damage buff
happypurpleduck Jun 9, 2019
895193e
reset skillDetail when skill changes
happypurpleduck Jun 9, 2019
80fab3e
Merge branch 'master' into master
happypurpleduck Jun 10, 2019
272d7e0
Update global_logic.js
happypurpleduck Jun 10, 2019
addedab
Update global_logic.js
happypurpleduck Jun 10, 2019
b382124
Update global_logic.js
happypurpleduck Jun 10, 2019
2f9882b
create supplemental.js
happypurpleduck Jun 11, 2019
aa5d214
Update supplemental.test.js
happypurpleduck Jun 11, 2019
ed9776b
supplemental function simplify
happypurpleduck Jun 11, 2019
2ef842c
change function export in supplemental
happypurpleduck Jun 11, 2019
f2cef8e
Update result.js
happypurpleduck Jun 11, 2019
b4280d0
Better Filtering
happypurpleduck Jun 11, 2019
d1cf506
Merge branch 'master' into master
happypurpleduck Jun 11, 2019
9d91406
Update supplemental damage table logic
happypurpleduck Jun 11, 2019
a3a29d1
Merge branch 'master' of https://github.com/h-yasha/motocal
happypurpleduck Jun 11, 2019
8c87ded
Merge branch 'master' into master
happypurpleduck Jun 11, 2019
9b7496d
Merge branch 'master' into master
Groovman Jun 11, 2019
ef97443
clean up
happypurpleduck Jun 11, 2019
b93f54a
Merge branch 'master' of https://github.com/h-yasha/motocal
happypurpleduck Jun 11, 2019
2ec15e2
supplemental info table changes
happypurpleduck Jun 11, 2019
583c124
Various Enhancement and Update supplemental.test.js
happypurpleduck Jun 12, 2019
f3e98b6
Update supplemental.test.js
happypurpleduck Jun 12, 2019
8110b22
add unit test for tableHeader
happypurpleduck Jun 12, 2019
cd5aaf0
Merge branch 'master' into master
happypurpleduck Jun 13, 2019
ae076f1
Remove supplemental.js module dependency
kei-gbf Jun 13, 2019
7ef2801
Merge pull request #4 from kei-gbf/review-pr233
happypurpleduck Jun 13, 2019
26f150b
Update translate.js
happypurpleduck Jun 14, 2019
f9c2498
change AdditionalVal to extraValue
happypurpleduck Jun 14, 2019
0706a1e
Merge branch 'master' into master
happypurpleduck Jun 15, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/global_logic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2762,7 +2762,7 @@ module.exports.generateHaisuiData = function (res, arml, summon, prof, chara, st
haisuiBuff[l]["normalKonshin"] += 0.01 * module.exports.calcHaisuiValue("omegaKonshin", amount, slv, remainHP)
}
omegaKonshinIncluded = true;
}
}
kei-gbf marked this conversation as resolved.
Show resolved Hide resolved
} else if (onedata[key].element == element) {
if (isHaisuiType(stype)) {
if (stype === "normalHaisui" || stype === "normalKonshin") {
Expand All @@ -2787,10 +2787,9 @@ module.exports.generateHaisuiData = function (res, arml, summon, prof, chara, st
}
}
}
}
}//
}
}

for (var k = 0; k < 100; k++) {
var newTotalSkillCoeff = totalSkillWithoutHaisui * haisuiBuff[k].normalHaisui * haisuiBuff[k].magnaHaisui * haisuiBuff[k].normalKonshin * haisuiBuff[k].magnaKonshin * haisuiBuff[k].charaHaisui * haisuiBuff[k].exHaisui * haisuiBuff[k].lbHaisui * haisuiBuff[k].lbKonshin;
var summedAttack = onedata[key].displayAttack;
Expand All @@ -2799,13 +2798,32 @@ module.exports.generateHaisuiData = function (res, arml, summon, prof, chara, st

var newDamage = module.exports.calcDamage(summedAttack, newTotalSkillCoeff, onedata[key].criticalRatio, prof.enemyDefense, prof.defenseDebuff, onedata[key].skilldata.additionalDamage, onedata[key].skilldata.damageUP, onedata[key].skilldata.damageLimit)
var newOugiDamage = module.exports.calcOugiDamage(summedAttack, newTotalSkillCoeff, onedata[key].criticalRatio, prof.enemyDefense, prof.defenseDebuff, onedata[key].ougiRatio, onedata[key].skilldata.ougiDamageUP, onedata[key].skilldata.damageUP, onedata[key].skilldata.ougiDamageLimit)

for (var supplementalDamageKey in onedata[key].skilldata.supplementalDamageArray) {
if (supplementalDamageKey == 'impervious' && k >= 80) {
newDamage += onedata[key].skilldata.supplementalDamageArray[supplementalDamageKey].damage;
newOugiDamage += onedata[key].skilldata.supplementalDamageArray[supplementalDamageKey].ougiDamage;
} else if (supplementalDamageKey != 'contentious' && supplementalDamageKey != 'impervious') {
newDamage += onedata[key].skilldata.supplementalDamageArray[supplementalDamageKey].damage;
newOugiDamage += onedata[key].skilldata.supplementalDamageArray[supplementalDamageKey].ougiDamage;
//damageWithoutCritical += onedata[key].skilldata.supplementalDamageArray[supplementalDamageKey].damageWithoutCritical;
}
}

var chainNumber = !isNaN(prof.chainNumber) ? parseInt(prof.chainNumber) : 1;
var newChainBurst = module.exports.calcChainBurst(chainNumber * newOugiDamage, chainNumber, module.exports.getTypeBonus(onedata[key].element, prof.enemyElement), onedata[key].skilldata.chainDamageUP, onedata[key].skilldata.chainDamageLimit) / chainNumber;
var newExpectedCycleDamagePerTurn = (onedata[key].expectedTurn === Infinity)
? (onedata[key].expectedAttack * newDamage)
: (newChainBurst + newOugiDamage + onedata[key].expectedTurn * onedata[key].expectedAttack * newDamage) / (onedata[key].expectedTurn + 1);

: (newChainBurst + newOugiDamage + onedata[key].expectedTurn * onedata[key].expectedAttack * newDamage);

if (onedata[key].skilldata.supplementalDamageArray['contentious'] != undefined) {
newExpectedCycleDamagePerTurn += onedata[key].skilldata.supplementalDamageArray.contentious.damage;
newDamage += onedata[key].skilldata.supplementalDamageArray.contentious.damage;
//damageWithoutCritical += onedata[key].skilldata.supplementalDamageArray.contentious.damageWithoutCritical;
}

newExpectedCycleDamagePerTurn /= (onedata[key].expectedTurn + 1);

var hp;
if (displayRealHP) {
// Actual HP
Expand Down