Fix context in beforeEach call (unittest) #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was happen by the difference between Jasmin(CodePen) and Jest(Motocal) It's repored in official jest issue Jest fixed the re-use of `this` context as bug. (it's implicitly context binding to use `this` in test code) so Jasmin's test code does will not work in Jest. This patch is required in MotocalDevelopers#201
|
Neither solution fails for me. How do you reproduce this error? |
|
fail? at least current status is shown ok (TravisCI Details in this PR) The error was produced 2492295 in #201, you can see the the full log in Travis CI detail I was missing to note that, this is patch to #201 (for now) then I will change PR title: The summary will be:
Problem is, non of current motocal code did not use import/export syntax. |
|
Oh okay, I pulled onto master and tried it. I'll try this PR changes on #201. |
OrkunKocyigit
approved these changes
Jun 20, 2019
kei-gbf
added a commit
to kei-gbf/motocal
that referenced
this pull request
Jun 26, 2019
missing in MotocalDevelopers#266 I noticed after merged. this fix is required in MotocalDevelopers#201
kei-gbf
added a commit
to kei-gbf/motocal
that referenced
this pull request
Jun 26, 2019
missing in MotocalDevelopers#266 I noticed after merged. this fix is required in MotocalDevelopers#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was happen by the difference between Jasmin(CodePen) and Jest(Motocal)
It's repored in official jest issue jestjs/jest#3553
Jest fixed the re-use of
thiscontext as bug.(it's actually implicitly context binding to use
thisin test code)so Jasmin's test code will not work in Jest.
This patch is required in #201
Here is current #201 test result, it changes babel setting for jest (test only change)
This patch only change the test code, that just moving the variable context/scope.
No effects to Motocal main code at all. So it's safe to Approve if Travis status shows green.
@h-yasha just mention for update unit test info
my test code not work in Jest (maybe in future when library updated)
we can't writelet {variable} = this;in Jest code anymore.we should not use
thiscontext variable in test code.