Custom hotkeys don't work on users that partially match reserved names

[monk-time]

The script for adding custom hotkeys breaks if a repo owner partially matches any of Github's reserved names. For example, hotkeys don't work on git-for-windows/git because it has 'windows' in the owner's name.

This seems to be caused by JS testing a regex at all positions in a given string instead of only at the start (even without a global flag):

GitHub-userscripts/github-custom-hotkeys.user.js

Lines 56 to 80 in a591264

	nonUser = new RegExp("(" + [
	"400", "401", "402", "403", "404", "405", "406", "407", "408", "409",
	"410", "411", "412", "413", "414", "415", "416", "417", "418", "419",
	"420", "421", "422", "423", "424", "425", "426", "427", "428", "429",
	"430", "431", "500", "501", "502", "503", "504", "505", "506", "507",
	"508", "509", "510", "511", "about", "access", "account", "admin",
	"anonymous", "api", "apps", "auth", "billing", "blog", "business",
	"cache", "categories", "changelog", "codereview", "comments", "community",
	"compare", "contact", "dashboard", "design", "developer", "docs",
	"downloads", "editor", "edu", "enterprise", "events", "explore",
	"features", "files", "gist", "gists", "graphs", "help", "home", "hosting",
	"images", "info", "integrations", "issues", "jobs", "join", "languages",
	"legal", "linux", "lists", "login", "logout", "mac", "maintenance",
	"marketplace", "mine", "mirrors", "mobile", "navigation", "network",
	"new", "news", "notifications", "oauth", "offer", "open-source",
	"organizations", "orgs", "pages", "payments", "personal", "plans",
	"plugins", "popular", "posts", "press", "pricing", "projects", "pulls",
	"readme", "releases", "repositories", "search", "security", "services",
	"sessions", "settings", "shop", "showcases", "signin", "signup", "site",
	"ssh", "staff", "stars", "static", "status", "store", "stories",
	"styleguide", "subscriptions", "support", "talks", "teams", "terms",
	"tos", "tour", "translations", "trending", "updates", "username", "users",
	"watching", "wiki", "windows", "works-with", "www1", "www2", "www3",
	"www4", "www5", "www6", "www7", "www8", "www9"
	].join("|") + ")");

GitHub-userscripts/github-custom-hotkeys.user.js

Lines 98 to 102 in a591264

	// user name
	if (nonUser.test(tmp[1] || "")) {
	// invalid user! clear out the values
	tmp = [];
	}

I think this issue can be safely fixed by surrounding the regex with ^ and $.

P.S. Also it seems like the {me} scope is always undefined:

GitHub-userscripts/github-custom-hotkeys.user.js

Lines 91 to 93 in a591264

	let tmp = $("meta[name='user-login']");
	parts.m = tmp && tmp.getAttribute("content") || "";
	parts.me = parts.me ? parts.root + "/" + parts.m : "";

[Mottie]

Hi @monk-time!

Thanks for letting me know about this problem. I'll have it fixed soon.