toggle expanders also starts to edit the PR title #8
Comments
|
Hi @aspiers! Do you have an example page that I can look at? I know it won't work for me as I won't be a collaborator, but the layout of the page may help me isolate this issue. |
|
Sure: try this one: https://github.com/crowbar/crowbar-core/pull/575/commits |
|
Great thanks! It should be all fixed now! |
|
Confirmed it works - awesome! |
cmalard
added a commit
to cmalard/GitHub-userscripts
that referenced
this issue
Jun 15, 2017
I have chosen to handle the click only for the current review, not all reviews done in the PR wich could be too much (and less interesting from my use case -> check everything is OK for one review) So the selector is `.discussion-item-body` and not `.js-discussion` I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix Mottie#8
This was referenced Jun 15, 2017
cmalard
added a commit
to cmalard/GitHub-userscripts
that referenced
this issue
Jun 16, 2017
I have chosen to handle the click only for the current review, not all reviews done in the PR wich could be too much (and less interesting from my use case -> check everything is OK for one review) So the selector is `.discussion-item-body` and not `.js-discussion` I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix Mottie#8
cmalard
added a commit
to cmalard/GitHub-userscripts
that referenced
this issue
Jun 16, 2017
I have chosen to handle the click only for the current review, not all reviews done in the PR wich could be too much (and less interesting from my use case -> check everything is OK for one review) So the selector is `.discussion-item-body` and not `.js-discussion` I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix Mottie#8
cmalard
added a commit
to cmalard/GitHub-userscripts
that referenced
this issue
Jun 16, 2017
I have chosen to handle the click only for the current review, not all reviews done in the PR wich could be too much (and less interesting from my use case -> check everything is OK for one review) So the selector is `.discussion-item-body` and not `.js-discussion` I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix Mottie#8
cmalard
added a commit
to cmalard/GitHub-userscripts
that referenced
this issue
Jun 16, 2017
To toggle all outdated blocks for the current review : Shift+Click To toggle all outdated blocks in the PR : Ctrl+Shift+Click I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix Mottie#8
Mottie
pushed a commit
that referenced
this issue
Jun 16, 2017
To toggle all outdated blocks for the current review : Shift+Click To toggle all outdated blocks in the PR : Ctrl+Shift+Click I had to refactor to match the closest parent. As a consequence, there is no longer the need to support `#commits_bucket` to fix #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As reported at https://greasyfork.org/en/forum/discussion/11753/x; filing here to ease tracking of resolution :-) Thanks!
The text was updated successfully, but these errors were encountered: