-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved AJAX support #183
Conversation
Oh man, I didn't see this pull request until I just pushed a fix for the pager. I'll have to look at what you've done. Thanks for all the work you've done! |
to see a compare of his master vs your master (with whitespace changes ignore) view: |
note, people really need to stop changing line endings... makes it hard to diff the actual changes. |
Thanks @thezoggy! I'll look into doing the normalization in the next update too :) |
It appears that I accidentally included an unrelated change that I was using to hide table filter inputs on hidden columns. This causes some trouble if your table is hidden on page load though, so you'd probably want to avoid including this.
|
@dhamma I hate to ask, but can you resubmit this pull request so I can merge it with the current version. It'll speed things up for me in these days of very limited time. That, and I still need to learn how to cherry pick a pull request 😋 |
Alright, it looks like the changes automatically pulled into here, and the line endings look better. |
id say rebase and push a new one. otherwise you will have some dirty commit history and git blame will always show you as you changed the files one way then back |
It looks like the blame shows up alright on the site and on my windows box; though, I haven't checked on a linux box. I can rebase if you'd like @Mottie, just let me know. Bad compare: Fervens/tablesorter@Mottie:master...5422244 |
… re-triggered continuously and AJAX error handling being bound too many times. It also adds support for passing filtering parameters with the AJAX request.
I was having trouble figuring out how to rebase since I had previously merged, so I ended up just applying the merged changes in a single commit. |
The pager previously had some support for AJAX paging. This patch fixes issues with update events being re-triggered continuously and AJAX error handling being bound too many times. It also adds support for passing filtering parameters with the AJAX request. If you have any issues/suggestions with the patch please let me know.