Skip to content

Commit

Permalink
fix(ModuleManager): loosen auto-generated dependency version
Browse files Browse the repository at this point in the history
getNextPatchVersion was too narrow when the base version was a snapshot.

(That may be a gestalt-module bug, but it's an edge case and using MinorVersion here seems fine.)
  • Loading branch information
keturn committed Apr 2, 2021
1 parent 2f9d4af commit 20546f1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private void ensureModulesDependOnEngine() {
DependencyInfo engineDep = new DependencyInfo();
engineDep.setId(engineModule.getId());
engineDep.setMinVersion(engineModule.getVersion());
engineDep.setMaxVersion(engineModule.getVersion().getNextPatchVersion());
engineDep.setMaxVersion(engineModule.getVersion().getNextMinorVersion());

HashSet<Name> engineModules = Sets.newHashSet(engineModule.getId());
engineModules.addAll(engineModule.getMetadata().getDependencies().stream().map(DependencyInfo::getId).collect(Collectors.toList()));
Expand Down

0 comments on commit 20546f1

Please sign in to comment.