-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix debug for skeleton renderer #4863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
changed the title
bugfix: correct skeleton renderer
bugfix: correct skeleton renderer (https://github.com/MovingBlocks/Terasology/pull/4827)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (https://github.com/MovingBlocks/Terasology/pull/4827)
bugfix: correct skeleton renderer (Terasology/4856)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (Terasology/4856)
bugfix: correct skeleton renderer (#4856)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (#4856)
bugfix: correct skeleton renderer (MovingBlocks/Terasology/48634856)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (MovingBlocks/Terasology/48634856)
bugfix: correct skeleton renderer (MovingBlocks/Terasology/4856)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (MovingBlocks/Terasology/4856)
bugfix: correct skeleton renderer (Terasology/4856)
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer (Terasology/4856)
bugfix: correct skeleton renderer (#4856)
Aug 22, 2021
pollend
force-pushed
the
bugfix/skeletal-renderer-debug-4856
branch
from
August 22, 2021 02:13
a459bf1
to
2784d93
Compare
pollend
changed the title
bugfix: correct skeleton renderer (#4856)
bugfix: correct skeleton renderer
Aug 22, 2021
pollend
changed the title
bugfix: correct skeleton renderer
bugfix: fix debug for skeleton renderer
Aug 23, 2021
skaldarnar
reviewed
Aug 26, 2021
@@ -60,11 +57,25 @@ | |||
@In | |||
private WorldRenderer worldRenderer; | |||
|
|||
@In | |||
protected AssetManager assetManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks checkstyle analysis 🤓
skaldarnar
approved these changes
Aug 26, 2021
skaldarnar
added
the
Topic: Rendering
Requests, Issues and Changes related to lighting, meshes, camera, etc.
label
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Topic: Rendering
Requests, Issues and Changes related to lighting, meshes, camera, etc.
Type: Bug
Issues reporting and PRs fixing problems
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I corrected the render overlay for skeleton renderer.
issue: #4856