Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(IntelliJ): turn on checkstyle.scan-before-checkin #4891

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

keturn
Copy link
Member

@keturn keturn commented Sep 5, 2021

Small tweaks to how CheckStyle is setup in gradle and IntelliJ.

The most impactful one is that scan-before-checkin.

I was tempted to see if we could get rid of the samedir property, but that princess is in another castle.

@keturn keturn added the Size: S Small effort likely only affecting a single area and requiring little to no research label Sep 5, 2021
@github-actions github-actions bot added the Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. label Sep 5, 2021
@keturn
Copy link
Member Author

keturn commented Sep 5, 2021

* What went wrong:
Execution failed for task ':engine:checkstyleJmh'.
> Unable to store input properties for task ':engine:checkstyleJmh'. Property 'configProperties' with value '{samedir=extension 'checkstyle' property 'configDirectory'}' cannot be serialized.

@keturn
Copy link
Member Author

keturn commented Sep 5, 2021

fixed. There was some groovy/gradle typing hijinks going on that threw a wrench in the first attempt.

@jdrueckert jdrueckert merged commit 05d7893 into develop Sep 9, 2021
@jdrueckert jdrueckert deleted the chore/ideaCheckstyle branch September 9, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants