Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove multi-world support #5116

Merged
merged 25 commits into from
Jul 17, 2023

refactor: remove 'add' and 'config' logic from Universe Setup Screen

3f091ba
Select commit
Loading
Failed to load commit list.
Merged

refactor!: remove multi-world support #5116

refactor: remove 'add' and 'config' logic from Universe Setup Screen
3f091ba
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Terasology Jenkins.io / PMD succeeded Jul 13, 2023 in 0s

7 new issues, 381 total.

Total New Outstanding Fixed Trend
381 7 374 5 👎

Reference build: Terasology » engine » develop #7

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 7 0

Annotations

Check warning on line 149 in engine/src/main/java/org/terasology/engine/logic/players/LocalPlayerSystem.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedLocalVariable

NORMAL:
Avoid unused local variables such as 'viewRotation'.
Raw output
Detects when a local variable is declared and/or assigned, but not used. Variables whose name starts with `ignored` or `unused` are filtered out. <pre> <code> public class Foo { public void doSomething() { int i = 5; // Unused } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedlocalvariable"> See PMD documentation. </a>

Check warning on line 70 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/StartPlayingScreen.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedLocalVariable

NORMAL:
Avoid unused local variables such as 'uri'.
Raw output
Detects when a local variable is declared and/or assigned, but not used. Variables whose name starts with `ignored` or `unused` are filtered out. <pre> <code> public class Foo { public void doSomething() { int i = 5; // Unused } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedlocalvariable"> See PMD documentation. </a>

Check warning on line 71 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/StartPlayingScreen.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedLocalVariable

NORMAL:
Avoid unused local variables such as 'worldInfo'.
Raw output
Detects when a local variable is declared and/or assigned, but not used. Variables whose name starts with `ignored` or `unused` are filtered out. <pre> <code> public class Foo { public void doSomething() { int i = 5; // Unused } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedlocalvariable"> See PMD documentation. </a>

Check warning on line 71 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/UniverseSetupScreen.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedPrivateField

NORMAL:
Avoid unused private fields such as 'logger'.
Raw output
Detects when a private field is declared and/or assigned a value, but not used. Since PMD 6.50.0 private fields are ignored, if the fields are annotated with any annotation or the enclosing class has any annotation. Annotations often enable a framework (such as dependency injection, mocking or e.g. Lombok) which use the fields by reflection or other means. This usage can't be detected by static code analysis. Previously these frameworks where explicitly allowed by listing their annotations in the property "ignoredAnnotations", but that turned out to be prone of false positive for any not explicitly considered framework. <pre> <code> public class Something { private static int FOO = 2; // Unused private int i = 5; // Unused private int j = 6; public int addOne() { return j++; } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedprivatefield"> See PMD documentation. </a>

Check warning on line 273 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/WorldPreGenerationScreen.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

AvoidPrintStackTrace

NORMAL:
Avoid printStackTrace(); use a logger call instead.
Raw output
Avoid printStackTrace(); use a logger call instead. <pre> <code> class Foo { void bar() { try { // do something } catch (Exception e) { e.printStackTrace(); } } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#avoidprintstacktrace"> See PMD documentation. </a>

Check warning on line 72 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/WorldSetupScreen.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedLocalVariable

NORMAL:
Avoid unused local variables such as 'worldPreGenerationScreen'.
Raw output
Detects when a local variable is declared and/or assigned, but not used. Variables whose name starts with `ignored` or `unused` are filtered out. <pre> <code> public class Foo { public void doSomething() { int i = 5; // Unused } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedlocalvariable"> See PMD documentation. </a>

Check warning on line 72 in engine/src/main/java/org/terasology/engine/rendering/world/WorldRendererImpl.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedPrivateField

NORMAL:
Avoid unused private fields such as 'GROUND_PLANE_HEIGHT_DISPARITY'.
Raw output
Detects when a private field is declared and/or assigned a value, but not used. Since PMD 6.50.0 private fields are ignored, if the fields are annotated with any annotation or the enclosing class has any annotation. Annotations often enable a framework (such as dependency injection, mocking or e.g. Lombok) which use the fields by reflection or other means. This usage can't be detected by static code analysis. Previously these frameworks where explicitly allowed by listing their annotations in the property "ignoredAnnotations", but that turned out to be prone of false positive for any not explicitly considered framework. <pre> <code> public class Something { private static int FOO = 2; // Unused private int i = 5; // Unused private int j = 6; public int addOne() { return j++; } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedprivatefield"> See PMD documentation. </a>