-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix gradle warnings #5130
refactor: fix gradle warnings #5130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall these changes look very reasonable to me, but I did not test them yet.
val artifactView = resolvable.artifactView { | ||
lenient(true) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer needed or no longer possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it made no difference to building the project, artifactView
may have been used before but not anymore. I believe all that method does is create a builder, but since it used nowhere in the function it is kinda pointless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡
@skaldarnar as you approved as is: setting the kotlin version to something outdated should not be done, "4.0.14". the future kotlin version is fine as gradle-8.3 will be merged next and has this new version anyway. spotbugs needs this one as well to really run: #5126 . |
Well, at compile time it complains about using a newer version. It even says what version to use. @soloturn could you point me to where spotbugs gradle plug-in requires a certain kotlin version? Can't find anything anywhere on their repo |
I think this is what I observed as well. I don't like using old(er) versions, but if the specific lineup of tools explicitly requires some version we have to figure that out somehow. I'm more than happy if we can upgrade to a newer version with the next Gradle release, but looking at the past I'd expect that we have to use a specifc (by then outdated) version until there's another upgrade for Gradle available. Let's merge things one by one, and we'll hopefully end up in a state where we use a modern Gradle with a modern Kotlin running moder Spotbugs 🙃 |
@skaldarnar I could add a comment to remind us to upgrade maybe? |
this pull request includes 2 things too much which imo should be taken out:
|
Afaik there are no plans to support Java 20, just Java 17 for now. Also specifying versions is better in the long run, version mismatches makes things be a bit more of a pain, but it is clear when an update is required and what may cause a compilation issue which could be hard to debug. |
@soloturn I merged #5126 and the java 20 issue is not a problem at the moment as we're targeting java 20 only at a later point. For the next milestone, java 17 is the target. @PurityLake can you please update the PR with the latest state of develop? |
umm... whoops... didn't recall that effect on PRs from forks, sorry 🙈 |
@PurityLake can you please open the pr please? |
Contains
Addresses #5127
This should be added into #5109
How to test
./gradlew wrapper --warning-mode all
Outstanding before merging
I made some changes to the versions of some plugins due to the version being older, so they were using deprecated functions.
protobuf
->0.9.4
spotbug
->5.1.3