Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version of sccache if no version is specified #27

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Mar 22, 2023

Closes #25

I'm not using the @actions/github package since it requires a token.
But the side effect is that we might encounter an API rate limit like the following:

HttpClientError: API rate limit exceeded for 207.254.3.33. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

@sylvestre sylvestre requested a review from Xuanwo March 22, 2023 08:14
@sylvestre
Copy link
Collaborator

i landed a change. could you please rebase your patch to fix the conflict on dist/setup/index.js ? thanks

src/setup.ts Outdated Show resolved Hide resolved
@sylvestre
Copy link
Collaborator

great work btw :)

@miles170 miles170 force-pushed the download-latest-if-no-version branch from 9b5ff03 to 2dd2bce Compare March 22, 2023 09:58
@miles170 miles170 force-pushed the download-latest-if-no-version branch from 2dd2bce to 580dce4 Compare March 22, 2023 10:19
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@Xuanwo Xuanwo merged commit 36cc091 into Mozilla-Actions:main Mar 22, 2023
@miles170 miles170 deleted the download-latest-if-no-version branch March 22, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when no version specificed, download the latest release
3 participants