Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize PNI template strings #4239

Merged
merged 19 commits into from
Mar 19, 2020
Merged

Localize PNI template strings #4239

merged 19 commits into from
Mar 19, 2020

Conversation

TheoChevalier
Copy link
Contributor

Long, but straight-forward PR.
Similarly to the MozFest PR, I’m wrapping all template strings for PNI l10n.
I also removed /en from some links in the process

@TheoChevalier TheoChevalier requested a review from Pomax February 21, 2020 09:59
@patjouk patjouk temporarily deployed to foundation-s-pni-i18n-1ujzqir3 February 21, 2020 09:59 Inactive
@patjouk patjouk temporarily deployed to foundation-s-pni-i18n-1ujzqir3 February 21, 2020 13:34 Inactive
@cadecairos cadecairos added this to the Mar 9 milestone Feb 26, 2020
@TheoChevalier TheoChevalier mentioned this pull request Feb 27, 2020
Closed
Pomax
Pomax suggested changes Mar 3, 2020
View reviewed changes
network-api/networkapi/buyersguide/templates/about/why_we_made.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/about/why_we_made.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/bg_base.html Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/buyersguide_home.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/buyersguide_home.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/fragments/seal_of_approval.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/product_page.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/product_page.html Outdated Show resolved Hide resolved
@TheoChevalier TheoChevalier requested a review from Pomax March 4, 2020 14:31
@gideonthomas gideonthomas modified the milestones: Mar 9, Mar 23 Mar 11, 2020
Pomax
Pomax suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things, after that: R+

network-api/networkapi/buyersguide/templates/about/methodology.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/bg_base.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/buyersguide_home.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/fragments/adult_content_badge.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/fragments/adult_content_badge.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/product_page.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/product_page.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/product_page.html Outdated Show resolved Hide resolved
network-api/networkapi/buyersguide/templates/fragments/product_contact.html Show resolved Hide resolved
@TheoChevalier TheoChevalier requested a review from Pomax March 12, 2020 17:50
@TheoChevalier
Copy link
Contributor Author

TheoChevalier commented Mar 12, 2020 •
edited
Loading

@Pomax Thanks, committed all your suggestions and this is the only thing I’ve updated myself: 7c4c9ba

If that looks good to you, happy to merge away

@TheoChevalier TheoChevalier force-pushed the PNI-i18n branch 2 times, most recently from 9c4128e to fee2ab1 Compare March 18, 2020 19:45
TheoChevalier and others added 13 commits March 18, 2020 19:50
@TheoChevalier
PNI i18n
5e9fd83
@TheoChevalier
Keep short date format
eeb925a
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/buyersguide_home.…
761c016 
…html

Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/buyersguide_home.…
4258381 
…html

Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier
Review fixes
4c9c807
@TheoChevalier
use localize template filter instead of template tag
f715ba7
@TheoChevalier
Update contact
35d9bef
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/about/methodology…
26f5480 
….html

Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/buyersguide_home.…
ff83449 
…html

Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/fragments/adult_c…
6ac088f 
…ontent_badge.html

Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/product_page.html
251a6f1 
Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/product_page.html
9c3e831 
Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier @Pomax
Update network-api/networkapi/buyersguide/templates/product_page.html
e82b258 
Co-Authored-By: Pomax <pomax@nihongoresources.com>
@TheoChevalier TheoChevalier requested a review from Pomax March 19, 2020 17:47
Pomax
Pomax approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go go go!

@Pomax Pomax merged commit 6f070b1 into master Mar 19, 2020
@Pomax Pomax deleted the PNI-i18n branch March 19, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pomax Pomax Pomax approved these changes

Assignees

@TheoChevalier TheoChevalier

Labels
None yet
Projects
None yet
Milestone
Mar 23
Development

Successfully merging this pull request may close these issues.
5 participants
@TheoChevalier @Pomax @cadecairos @patjouk @gideonthomas