Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect /opportunity pages to /initiatives #4248

Merged
merged 18 commits into from
Mar 19, 2020

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Feb 24, 2020

Related to #2971

Wagtail page has been moved to /initiatives

English

https://foundation-s-issue-2971-2zw1sx.herokuapp.com/en/initiatives/page-has-been-moved-initiatives/ (link should redirect to /en/initiatives/...)

French

https://foundation-s-issue-2971-2zw1sx.herokuapp.com/fr/initiatives/page-has-been-moved-initiatives/ (link should redirect to /fr/initiatives/...)

Wagtail page has * not * been moved to /initiatives yet

English

https://foundation-s-issue-2971-2zw1sx.herokuapp.com/en/opportunity/page-still-under-opportunity/ (link redirects to /en/initiatives/... but it's a 404 since we haven't moved the page yet)

French

https://foundation-s-issue-2971-2zw1sx.herokuapp.com/fr/opportunity/page-still-under-opportunity/ (link redirects to /fr/initiatives/... but it's a 404 since we haven't moved the page yet)

@patjouk patjouk temporarily deployed to foundation-s-issue-2971-mlo0uu February 24, 2020 20:52 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 24, 2020 21:29 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 24, 2020 22:33 Inactive
@mmmavis mmmavis changed the title (WIP) Redirect /opportunity pages to /initiatives (DO NOT MERGE) Redirect /opportunity pages to /initiatives Feb 24, 2020
@mmmavis mmmavis changed the title (DO NOT MERGE) Redirect /opportunity pages to /initiatives (DO NOT MERGE YET) Redirect /opportunity pages to /initiatives Feb 24, 2020
@mmmavis mmmavis marked this pull request as ready for review February 24, 2020 22:37
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 24, 2020 23:06 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 24, 2020 23:07 Inactive
Pomax
Pomax previously requested changes Feb 24, 2020
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pomax
Copy link
Contributor

Pomax commented Feb 24, 2020

It's also doing pretty weird things when comparing localhost:8000/opportunity/... vs. localhost:8000/en/opportunity/... =(

@mmmavis
Copy link
Collaborator Author

mmmavis commented Feb 24, 2020

Ummm both test.example.com:8000/opportunity and test.example.com:8000/en/opportunity redirected me to test.example.com:8000/initiatives. 🤔

Copy link
Contributor

@gideonthomas gideonthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We'll have to test on prod for edge cases.
We have to manually move opportunity pages to initiatives right?

r+ once you fix the cypress test.

@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 25, 2020 17:42 Inactive
@cadecairos cadecairos added this to the Mar 9 milestone Feb 26, 2020
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 27, 2020 04:34 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-mlo0uu February 27, 2020 04:37 Inactive
@mmmavis mmmavis requested a review from Pomax February 27, 2020 16:53
@mmmavis
Copy link
Collaborator Author

mmmavis commented Feb 27, 2020

PR updated!

@Pomax I can't reproduce the issues you were having. Can you try out this PR again and let me know if you still run into issues?

@gideonthomas

We'll have to test on prod for edge cases.

What kind of edge cases?

We have to manually move opportunity pages to initiatives right?

Yea, we'll have to manually move those pages using the "move" button on Wagtail admin first before landing this PR.

@gideonthomas
Copy link
Contributor

edge cases that we don't know about haha. Basically I mean, run on prod and monitor if anything breaks. I don't see any issues with the implementation so the only thing I can think of that will break this is some random edge case we haven't thought about.

@Pomax Pomax temporarily deployed to foundation-s-issue-2971-u9kqiv March 3, 2020 19:24 Inactive
@Pomax
Copy link
Contributor

Pomax commented Mar 3, 2020

@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 9, 2020 20:52 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 01:19 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 20:16 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 20:18 Inactive
Co-Authored-By: Pomax <pomax@nihongoresources.com>
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 22:30 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 22:32 Inactive
@mmmavis mmmavis requested a review from Pomax March 10, 2020 22:32
@mmmavis mmmavis temporarily deployed to foundation-s-issue-2971-2zw1sx March 10, 2020 22:40 Inactive
@gideonthomas gideonthomas removed this from the Mar 9 milestone Mar 11, 2020
@mmmavis mmmavis removed the request for review from gideonthomas March 19, 2020 17:19
@mmmavis mmmavis changed the title (DO NOT MERGE YET) Redirect /opportunity pages to /initiatives Redirect /opportunity pages to /initiatives Mar 19, 2020
@mmmavis mmmavis merged commit 544df47 into master Mar 19, 2020
@mmmavis mmmavis deleted the issue-2971-opportunity-pages-redirect branch March 19, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants