Skip to content

Commit

Permalink
Fix the default tracing rule
Browse files Browse the repository at this point in the history
The evaluation of the expression checking the B3 header interpreted the
integer string as a duration instead of a string. Instead evaluate
against an empty string as this will equivalently result in false if
the header is not present.

Resolves newrelic#14
  • Loading branch information
Tyler Yahn committed Feb 21, 2020
1 parent 9d223f1 commit 7d25045
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## Unreleased

### Fixed

* The default tracing rule error for the incorrect parsed type in the rule expression is resolved. [#14](https://github.com/newrelic/newrelic-istio-adapter/issues/14)

## 2.0.1

### Added
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,6 @@ telemetry:
## The following can be uncommented if spans for inter-service communication
## should be sent to New Relic.
#newrelic-tracing:
# match: (context.protocol == "http" || context.protocol == "grpc") && destination.workload.name != "istio-telemetry" && destination.workload.name != "istio-pilot" && ((request.headers["x-b3-sampled"] | "0") == "1")
# match: (context.protocol == "http" || context.protocol == "grpc") && destination.workload.name != "istio-telemetry" && destination.workload.name != "istio-pilot" && ((request.headers["x-b3-sampled"] | "") == "1")
# instances:
# - newrelic-span

0 comments on commit 7d25045

Please sign in to comment.