Merge pull request #24 from MrDave1999/patch-2

test: Use FakeCarrier in the tests

tests/Application.Tests/Flags/FakeCarrier.cs

@@ -0,0 +1,16 @@
+namespace CTF.Application.Tests.Flags;
+
+public class FakeCarrier : Player
+{
+    public override bool SetAttachedObject(
+        int index,
+        int modelId,
+        Bone bone,
+        Vector3 offset,
+        Vector3 rotation,
+        Vector3 scale,
+        Color materialColor1,
+        Color materialColor2) => true;
+
+    public override bool RemoveAttachedObject(int index) => true;
+}

tests/Application.Tests/Flags/FlagTests.cs

@@ -12,10 +12,8 @@ public void IsCaptured_WhenFlagIsCapturedByPlayer_ShouldReturnsTrue()
             Name = "Red",
             ColorHex = Color.Red
         };
-        Player player = (Player)Activator.CreateInstance(type: typeof(Player), nonPublic: true);
-        flag.GetType()
-            .GetProperty(name: nameof(Flag.FlagCarrier))
-            .SetValue(flag, player);
+        var fakeCarrier = new FakeCarrier();
+        flag.SetCarrier(fakeCarrier);
 
         // Act
         bool actual = flag.IsCaptured();
@@ -63,6 +61,25 @@ public void SetCarrier_WhenArgumentIsNull_ShouldThrowArgumentNullException()
            .WithParameterName(nameof(player));
     }
 
+    [Test]
+    public void SetCarrier_WhenArgumentIsValid_ShouldSetPlayerAsCarrier()
+    {
+        // Arrange
+        var flag = new Flag
+        {
+            Model = FlagModel.Red,
+            Name = "Red",
+            ColorHex = Color.Red
+        };
+        var fakeCarrier = new FakeCarrier();
+
+        // Act
+        flag.SetCarrier(fakeCarrier);
+
+        // Assert
+        flag.FlagCarrier.Should().Be(fakeCarrier);
+    }
+
     [Test]
     public void RemoveCarrier_WhenNoPlayerHasCapturedFlag_ShouldNotThrowNullReferenceException()
     {
@@ -80,4 +97,24 @@ public void RemoveCarrier_WhenNoPlayerHasCapturedFlag_ShouldNotThrowNullReferenc
         // Assert
         act.Should().NotThrow<NullReferenceException>();
     }
+
+    [Test]
+    public void RemoveCarrier_WhenPlayerHasCapturedFlag_ShouldRemoveFlagOfThatPlayer()
+    {
+        // Arrange
+        var flag = new Flag
+        {
+            Model = FlagModel.Red,
+            Name = "Red",
+            ColorHex = Color.Red
+        };
+        var fakeCarrier = new FakeCarrier();
+        flag.SetCarrier(fakeCarrier);
+
+        // Act
+        flag.RemoveCarrier();
+
+        // Assert
+        flag.FlagCarrier.Should().BeNull();
+    }
 }