Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename enum member to BasePosition for better reflect its purpose #106

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

MrDave1999
Copy link
Owner

@MrDave1999 MrDave1999 commented Sep 22, 2024

"BasePosition" is the concept used in the game mode, while "InitialPosition" is too general.

@MrDave1999 MrDave1999 added the breaking-change Change API design or behavior label Sep 22, 2024
@MrDave1999 MrDave1999 marked this pull request as ready for review September 22, 2024 13:46
@MrDave1999 MrDave1999 merged commit ccdfb26 into dev Sep 22, 2024
1 check passed
@MrDave1999 MrDave1999 deleted the breaking-change branch September 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change API design or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant