refactor!: Use 'Exterior Marker' terminology instead of 'Pickup Info' #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“ExteriorMarker” is the conceptual model used in the project. See the models: * https://dev.prineside.com/en/gtasa_samp_model_id/model/19605-EnExMarker4-2 * https://dev.prineside.com/en/gtasa_samp_model_id/model/19607-EnExMarker4-4
…Marker “Exterior Marker” is the name of a pickup model that is created using the "IWorldService.CreatePickup" method, for that reason it was decided to change the public API for clarity. See the models: * https://dev.prineside.com/en/gtasa_samp_model_id/model/19605-EnExMarker4-2 * https://dev.prineside.com/en/gtasa_samp_model_id/model/19607-EnExMarker4-4
MrDave1999
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been decided to introduce a breaking change in the public API to use the term “Exterior Marker”, as this is the one being used in the project. This brings more clarity in the code.
See the models:
Image
Reference: https://dev.prineside.com/en/gtasa_samp_model_id/search/?q=EnExMarker
What is this pickup created for?
This pickup model is used to provide information to the player when their team's flag is captured by the enemy team.
What information is shown to the player?
A game text indicating that your team's flag is not in the base position and that you must retrieve it.