BREAKING CHANGE: Remove 'EntityId' property from 'PlayerInfo' class #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary to couple the "PlayerInfo" class with the "EntityId" type of SampSharp. The disadvantage of having an "EntityId" property, is that it enters in confusion with the AccountId property, at first sight the consumer does not know what is the difference between them, unless he checks the XML comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to couple the PlayerInfo class with the EntityId type of SampSharp.
Capture-The-Flag/src/Application/Players/Accounts/PlayerInfo.cs
Line 197 in 7753d2a
The comparison can be done using the player's name.
The disadvantage of having an EntityId property, is that it enters in confusion with the AccountId property, at first glance the consumer does not know what the difference between them is, unless they checks the XML comments.
This introduces a breaking change in the public API, so the EntityId would also have to be removed from the GetOrDefault method of the repository.