BREAKING CHANGE: Use ICombo interface instead of IBenefit #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was introduced because “ICombo” is that the represents the set of benefits that a player can obtain. “IBenefit” is not a good name, because it represents a single benefit and what we really want is to represent a set of benefits (a combo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was introduced because
ICombois that the represents the set of benefits that a player can obtain.IBenefitis not a good name, because it represents a single benefit and what we really want is to represent a set of benefits (a combo).ICombo: Represents a combination of different advantages, such as health, armour, and weapons, that a player can use to gain an advantage in the game.