Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DONT MERGE] 3.0.0 #1164

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[WIP] [DONT MERGE] 3.0.0 #1164

wants to merge 45 commits into from

Conversation

MrLuit
Copy link
Owner

@MrLuit MrLuit commented Jul 19, 2018

Changes

Desktop app

EtherScamDB can now be run locally using Electron. The desktop app contains some features which are disabled on the production website such as:

  • Light mode (won't run any IP/DNS/HTTP lookups)
  • A simple configuration process
  • A way to add scams to the data file locally

API

  • Breaking change: Removed id property from entries in _data/scams.yaml
  • Breaking change: Removed name property from entries in _data/scams.yaml
  • Breaking change: Removed id property from entries in _data/legit_urls.yaml
  • Added statusCode property to scam entries retrieved from the API with a completed lookup

Usability

  • Added warning to IP pages of private IPs (such as /ip/127.0.0.1)
  • Added Dockerfile for running application without having to deal with dependencies

Performance

  • Implemented direct communication between database and updating process (which means individual status updates get processed immediately, previously all scam lookups needed to be completed before the changes could be communicated to the database)
  • Rewrote everything to promises instead of callbacks
  • Implemented EJS templating (caching!)
  • Bottleneck implementation to have more control over maximum amount of requests/s (to prevent accidental DoS when performing lookups)

@MrLuit MrLuit changed the title Better updating process [WIP] [DONT MERGE] 3.0.0 Jul 21, 2018
@blurpesec blurpesec added the V3 Version 3.0.0 label Sep 15, 2018
@SGrondin
Copy link

I found this repo by searching for bottleneck on Github. Cool project and very clean use of Bottleneck 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete V3 Version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants