Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Implement history builtin #273

Closed
MrPicklePinosaur opened this issue Nov 21, 2023 · 3 comments
Closed

[Feature]: Implement history builtin #273

MrPicklePinosaur opened this issue Nov 21, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MrPicklePinosaur
Copy link
Owner

What would you like to see added?

See crates/shrs_core/src/builtins/history.rs

Implement basic history querying and running of previous commands. The shell interface that is currently outlined is a bit different from bash, so it is worth thinking if we should stick to our own syntax for history builtin or mimic the bash history builtin.
@MrPicklePinosaur MrPicklePinosaur added the enhancement New feature or request label Nov 21, 2023
This was referenced Nov 21, 2023
Closed
Closed
@MrPicklePinosaur MrPicklePinosaur added the good first issue Good for newcomers label Nov 28, 2023
@DavisRayM
Copy link

I'd like to pick this up if no one else is already working on it

@MrPicklePinosaur
Copy link
Owner Author

I'd like to pick this up if no one else is already working on it

go for it!

@MrPicklePinosaur
Copy link
Owner Author

blocked on #284

@MrPicklePinosaur MrPicklePinosaur mentioned this issue Dec 22, 2023
Closed
rithikasilva added a commit to rithikasilva/shrs that referenced this issue Jan 3, 2024
@rithikasilva
Initial Commit for MrPicklePinosaur#273
17c6fdd
@MrPicklePinosaur MrPicklePinosaur mentioned this issue Jan 4, 2024
Closed
MrPicklePinosaur pushed a commit that referenced this issue Jan 17, 2024
@rithikasilva
Implement History Builtin for #273 (#324)
28e6e5d 
* Initial Commit for #273

* History run (without running)

* Initial implementation of history search

* Added running using prompt_content_queue

* Add message for out of bounds index

* Simplify run code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavisRayM @MrPicklePinosaur