move shrs crate to crates/shrs #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably keep shrs_example in root directory (or |
not-my-profile
force-pushed
the
move-shrs-crate
branch
from
a1fa2c8
to
0b5bf0d
Compare
|
Ah, very good point! I didn't notice that the shrs_example also depended on the plugins. I updated this PR to keep it in the repository root. (I think that's better than having it in crates/ since then crates/ only contains crates that are published, which is nice.) |
We keep the shrs_example crate in the repository root since it depends on both the "shrs" crate, as well as the plugins, so having it under `crates/shrs/examples/` would be a bit arbitrary, since it rather acts as an integration test for all the crates and plugins. Resolves MrPicklePinosaur#233.
not-my-profile
force-pushed
the
move-shrs-crate
branch
from
0b5bf0d
to
b6d5234
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #233.