Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert plugin struct into state on init #298

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

MrPicklePinosaur
Copy link
Owner

@MrPicklePinosaur MrPicklePinosaur commented Dec 21, 2023

Previously if you wanted to add any form of configuration to a plugin, you would have to add a field to the plugin struct, then on initialization, create another struct with the field duplicated, copy the field over and insert the state. This was obviously really annoying, so now by default shrs will insert the plugin into state directly. This also provides a way to check if a plugin is installed to some extent

@MrPicklePinosaur MrPicklePinosaur merged commit 7e8d920 into master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant