Merge pull request #76 from MurhafSousli/new

v3.0.3
MurhafSousli · Feb 16, 2019 · e123264 · e123264
2 parents 49961b7 + 0bebf43
commit e123264
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 3.0.3
+
+- fix(HighlightChildren): fix `OnDestroy()` error (Cannot read property 'disconnect' of undefined), closes [#75](https://github.com/MurhafSousli/ngx-highlightjs/issues/75) in [3379905](https://github.com/MurhafSousli/ngx-highlightjs/commit/337990549984a5cc3007a7007273d562580e48f7).
+
 ## 3.0.2
 
 - fix(HighlightChildren): Highlight children not working inside `[innerHtml]`, closes [#67](https://github.com/MurhafSousli/ngx-highlightjs/issues/67) in [969f3b3](https://github.com/MurhafSousli/ngx-highlightjs/pull/73/commits/969f3b343f4a1015aa89dfca4625d64e4b1a28fd).

diff --git a/projects/ngx-highlightjs/package.json b/projects/ngx-highlightjs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-highlightjs",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "description": "Instant code highlighting, auto-detect language, super easy to use.",
   "homepage": "http://github.com/murhafsousli/ngx-highlightjs",
   "author": {

diff --git a/projects/ngx-highlightjs/src/lib/highlight-children.ts b/projects/ngx-highlightjs/src/lib/highlight-children.ts
@@ -60,6 +60,8 @@ export class HighlightChildren implements OnInit, OnDestroy {
   }
 
   ngOnDestroy() {
-    this._observer.disconnect();
+    if (this._observer) {
+      this._observer.disconnect();
+    }
   }
 }