Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gmc module #3

Open
wants to merge 123 commits into
base: master
Choose a base branch
from
Open

Update gmc module #3

wants to merge 123 commits into from

Conversation

etaletai13
Copy link
Contributor

This is more a suggestion to replace the module, with these. They are predictable, functional, and simple to include without knowing anything about the system. The package is pretty much entirely different than before, and so bumped up to 2.0.0, which is a package number and not the gmc version. But it'll tell you its version if you ask nicely yarn gmc version after yarn add gmc-bin

@Varunram
Copy link
Contributor

Yeah, this looks good but what does it do? This is just a change regarding the go-musicoin node package right?

@Varunram Varunram changed the title Not so much a merge request Update gmc module Sep 20, 2018
@etaletai13
Copy link
Contributor Author

It makes it so that it works the same way the 7zip-bin modules are supposed to work. There are different builds for each os and architecture, and it'll install the correct one and make it more easily available to use. It's worth the while.

@Varunram
Copy link
Contributor

The current module is on npm, so it should take care of each os and architecture as well. I'm finding it difficult to see the benefits, care to explain more?

@Varunram
Copy link
Contributor

Varunram commented Sep 21, 2018

Just as an addition, if you're thinking people should use the module to run their own instance of go-musicoin, that's redundant. If people want to run a node, they need to build and run the go-musicoin daemon. This module is only for use with the desktop wallet. We could do without the module in the wallet as well, but that would slightly complicate the build procedure for newcomers. But just as a note, we don't use the module to build the nightly versions.

@etaletai13
Copy link
Contributor Author

As with any other modification from me; it's in the interest of coders. I am starting to wonder why you are using node and that ecosystem when you'll refuse its benefits all around, and at each turn. This is here; take it or leave it I suppose. The benefits are clear to a coder wanting to write something that can work with musicoin using node, that's about it. If you'd like to remain hard on wanting manual bits as you seem to, I have little interest in spending time doing any of it correctly.

"nativefier musicoin.org" and then run gmc on its own. Bingo, more than what the plans are apparently. Again, take or leave. Either, your call and not mine. It's here.

@etaletai13 etaletai13 closed this Sep 21, 2018
@etaletai13 etaletai13 reopened this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants