Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

build: fix version comparison for go1.10 and beyond #91

Closed
wants to merge 1 commit into from
Closed

build: fix version comparison for go1.10 and beyond #91

wants to merge 1 commit into from

Conversation

teutat3s
Copy link

@teutat3s teutat3s commented Apr 2, 2018

build process stops without this commit when using latest Go Version (go1.10) on MacOS High Sierra. With this commit all works.

@5chdn
Copy link
Collaborator

5chdn commented Apr 3, 2018

Thanks, this is a real annoyance. 👍

@etaletai13
Copy link

That's bizarre. I could swear I JUST posted exactly this. But apparently you did! Hahahah either way at least I know I'm not the kind of crazy that thinks this is an issue erroneously.

Copy link

@etaletai13 etaletai13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm mistaken here; but might this be a time we should bump the build version of go for the project? I mean we're all trying to do this little hack to get it to build on a more recent release of go anyway, right?

@5chdn
Copy link
Collaborator

5chdn commented Apr 11, 2018

Yes, this was all fixed in #77 and reverted in #87. Now we are cherry-picking issues as we go.

@etaletai13
Copy link

@5chdn Awesome, thanks so much.

@etaletai13
Copy link

It still doesn't build on 1.10.1 without doing a sed s/1.7/1.10/g on build/ci.go

@Varunram
Copy link
Contributor

We're anyway planning to rebase stuff as part of #95, so lets take care of this there.

@Varunram Varunram closed this Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants