Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind Auth Follow Ups #1079

Closed
3 tasks done
benthecarman opened this issue Mar 25, 2024 · 8 comments · Fixed by #1105
Closed
3 tasks done

Blind Auth Follow Ups #1079

benthecarman opened this issue Mar 25, 2024 · 8 comments · Fixed by #1105

Comments

@benthecarman
Copy link
Collaborator

benthecarman commented Mar 25, 2024

  • Check for new tokens after mutiny+ subscription
  • Proper DM listening handling
  • save our lightning address in storage

follow up:
Add change federation functionality

@futurepaul
Copy link
Contributor

is there a way I can get a better error for if a name is already taken?

Screenshot 2024-03-26 at 4 32 01 PM

@TonyGiorgio
Copy link
Contributor

The check_name API call should be called first, and it returns a boolean value.

@futurepaul
Copy link
Contributor

The check_name API call should be called first, and it returns a boolean value.

ah nice

@TonyGiorgio
Copy link
Contributor

save our lightning address in storage

I've been thinking about how to do this. There's the naive approach of storing to local storage what the LN address should be. But what I'm thinking is that it can be a query to the hermes server.

We already know what the deterministic nostr pubkey will be for the user, so it can create a signed message from that nostr pubkey to something like /check-address which returns the federation id and the name for the user. That's the source of truth afterall. Anything we did locally would need to have some sort of cross check against the server.

Then from there, we can have federation changes happen the same way. We can see if the user's defined federation is different than the one stored on hermes. If so, then it creates a signed nostr message and then makes a request to /change-federation with the invite code it wants to change to.

Lastly (for a follow up some other day), to change names it can follow the same federation change flow, but for /change-name and it maybe just gets an invoice back that it has to pay to change the name?

@benthecarman
Copy link
Collaborator Author

That makes sense to me. I think we should try to do some local caching so we don't need to hit the server every time we boot up

@TonyGiorgio
Copy link
Contributor

What kind of caching do you think would be best here?

We can do something like a daily cache? Weekly?

Store it in local storage but not needed to be remotely backed up? If it's missing in local storage then it fetches remotely.

My main worry is from switching devices and not having the latest state if one of the devices changes federations or does the name change.

@benthecarman
Copy link
Collaborator Author

If we just store it in VSS then it should be fine

@TonyGiorgio
Copy link
Contributor

If we just store it in VSS then it should be fine

I want to avoid storing in VSS just to store in VSS.

@benthecarman benthecarman linked a pull request Apr 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants