Claim hermes tokens #1090
Merged
Claim hermes tokens #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
hermes-claim
branch
from
46f76f4
to
a736dc2
Compare
TonyGiorgio
requested changes
Mar 27, 2024
benthecarman
force-pushed
the
hermes-claim
branch
from
a736dc2
to
805e603
Compare
TonyGiorgio
approved these changes
Mar 27, 2024
|
Is this good to merge? It's still in draft. |
|
Left in draft because we're on an rc for Fedimint, not sure what our strategy is here Also haven't tested the zap decoding stuff |
|
needs rebase |
benthecarman
force-pushed
the
hermes-claim
branch
from
805e603
to
df77624
Compare
TonyGiorgio
reviewed
Apr 3, 2024
mutiny-core/src/hermes.rs
Outdated
| "Received DM for unknown federation {}", | ||
| notification.federation_id | ||
| ); | ||
| // todo should we save this to storage? |
There was a problem hiding this comment.
Save what in storage? The failed DM?
TonyGiorgio
approved these changes
Apr 3, 2024
benthecarman
force-pushed
the
hermes-claim
branch
from
df77624
to
fe92320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1079