Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better setup for new profiles #1125

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Better setup for new profiles #1125

merged 2 commits into from
Apr 11, 2024

Conversation

benthecarman
Copy link
Collaborator

No description provided.

@benthecarman benthecarman changed the title Unify relay list Better setup for new profiles Apr 9, 2024
@benthecarman
Copy link
Collaborator Author

benthecarman commented Apr 9, 2024 •
edited
Loading

todo expose to mutiny-web

done

TonyGiorgio
TonyGiorgio approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for me but needs @futurepaul's approval.

@benthecarman benthecarman force-pushed the unify-relays branch 2 times, most recently from 37401e7 to 345ba24 Compare April 10, 2024 22:36
@futurepaul
Copy link
Contributor

so I would just need to update the calls in NewProfile.tsx https://github.com/MutinyWallet/mutiny-web/blob/cdc7c880fa5fa4cdaf52bd7c0471cf8c817de2c5/src/routes/setup/NewProfile.tsx to use this? And pass in nothing in the handleSkip case? not sure what it simplifies from the frontend perspective otherwise

@benthecarman
Copy link
Collaborator Author

benthecarman commented Apr 10, 2024 •
edited
Loading

so I would just need to update the calls in NewProfile.tsx MutinyWallet/mutiny-web@cdc7c88/src/routes/setup/NewProfile.tsx to use this? And pass in nothing in the handleSkip case?

yeah pretty much, think you should still pass in the DEFAULT DEFAULT_NOSTR_NAME just for consistency

not sure what it simplifies from the frontend perspective otherwise

not meant to for you to be easier, supposed to make a follow list and relay list so new proifles are more portable to other nostr clients

@futurepaul futurepaul mentioned this pull request Apr 11, 2024
Merged
futurepaul
futurepaul approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me MutinyWallet/mutiny-web#1031

@benthecarman benthecarman merged commit 653a196 into master Apr 11, 2024
9 checks passed
@benthecarman benthecarman deleted the unify-relays branch April 11, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futurepaul futurepaul futurepaul approved these changes

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
nostr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benthecarman @futurepaul @TonyGiorgio