Get federation config from URL if available #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
force-pushed
the
federation-meta-parsing-2
branch
from
c51454d
to
ae520d3
Compare
benthecarman
approved these changes
May 7, 2024
|
I'll try this out now |
|
still seeing nulls sry:
|
|
Feel free to get in here and do it yourself, since you know how to test it and you know how to get it properly. |
|
I'll give it a shot |
|
This seems to work. No idea if I did the right thing in the merge_values section, I was just doing whatever the red squigglies told me to do 
|
|
Nice. Only thing that's not coming through is the |
futurepaul
force-pushed
the
federation-meta-parsing-2
branch
from
24dadc7
to
4f0d2a4
Compare
futurepaul
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@futurepaul can you test this out now? Should try to parse it correctly.