Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSS client #645

Merged
merged 10 commits into from
Jul 10, 2023
Merged

VSS client #645

merged 10 commits into from
Jul 10, 2023

Conversation

benthecarman
Copy link
Collaborator

No description provided.

TonyGiorgio
TonyGiorgio reviewed Jul 6, 2023
View reviewed changes
mutiny-core/src/auth.rs Outdated Show resolved Hide resolved
mutiny-core/src/vss.rs Show resolved Hide resolved
TonyGiorgio
TonyGiorgio approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and straitforward. Just a nit about not using anyhow otherwise LGTM.

TonyGiorgio
TonyGiorgio requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things but this looks as elegant as you could make it, at least for now. Very nice work, looking forward to testing this out!

mutiny-core/src/nodemanager.rs Show resolved Hide resolved
mutiny-core/src/storage.rs Show resolved Hide resolved
mutiny-core/src/vss.rs Outdated Show resolved Hide resolved
mutiny-core/src/vss.rs Outdated Show resolved Hide resolved
mutiny-core/src/vss.rs Outdated Show resolved Hide resolved
@TonyGiorgio
Copy link
Contributor

Wait where is the channel manager being saved? Only saw some call outs for monitor.

@benthecarman
Copy link
Collaborator Author

Wait where is the channel manager being saved? Only saw some call outs for monitor.

Didn't do that because it didn't have an easy version number. We'll have to implement our own versioning with it.

@TonyGiorgio
Copy link
Contributor

Wait where is the channel manager being saved? Only saw some call outs for monitor.

Didn't do that because it didn't have an easy version number. We'll have to implement our own versioning with it.

I think we'll have to do this though in order for this remote cloud feature to be useful. Do you think that's attainable as part of this PR?

@benthecarman
Copy link
Collaborator Author

I think we'll have to do this though in order for this remote cloud feature to be useful. Do you think that's attainable as part of this PR?

done

TonyGiorgio
TonyGiorgio requested changes Jul 10, 2023
View reviewed changes
mutiny-core/src/encrypt.rs Outdated Show resolved Hide resolved
mutiny-core/src/vss.rs Outdated Show resolved Hide resolved
mutiny-core/src/vss.rs Outdated Show resolved Hide resolved
@benthecarman benthecarman merged commit 25ed349 into master Jul 10, 2023
9 checks passed
@benthecarman benthecarman deleted the vss branch July 10, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benthecarman @TonyGiorgio