Skip to content

Commit

Permalink
Remove membership rewards button (#4271)
Browse files Browse the repository at this point in the history
* Remove rewards button

* Fix tests
  • Loading branch information
FrederikBolding authored Feb 2, 2022
1 parent e1be017 commit eab9fa1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion __tests__/membership.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ test('can buy with DAI', async (t) => {
await t.click(home);

await dashboard.waitPageLoaded();
const request = await queryByText(findByTKey('REQUEST_REWARDS'), { exact: false });
const request = await queryByText(findByTKey('MANAGE_MEMBERSHIP'), { exact: false });

await t.expect(request.exists).ok({ timeout: FIXTURES_CONST.HARDHAT_TIMEOUT });
});
1 change: 0 additions & 1 deletion src/config/helpArticles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export enum KB_HELP_ARTICLE {
STAYING_SAFE = 'staying-safe',
BUY_CRYPTO = 'how-to/getting-started/how-to-buy-ether-with-usd',
MEMBERSHIP_INFO = 'general-knowledge/about-mycrypto/membership-information',
MEMBERSHIP_REQUEST_REWARDS = 'general-knowledge/about-mycrypto/membership-information#how-to-receive-your-physical-rewards',
HOW_TO_USE_ZAPPER = 'how-to/defi/how-to-use-zapper',
WHERE_TO_GET_TESTNET_ETHER = 'how-to/getting-started/where-to-get-testnet-ether',
WHAT_IS_WALLETCONNECT = 'general-knowledge/ethereum-blockchain/what-is-walletconnect',
Expand Down
8 changes: 1 addition & 7 deletions src/features/Dashboard/components/MembershipPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styled from 'styled-components';
import expiredIcon from '@assets/images/membership/membership-expired.svg';
import defaultIcon from '@assets/images/membership/membership-none.svg';
import { Button, DashboardPanel, LinkApp, Typography } from '@components';
import { getKBHelpArticle, KB_HELP_ARTICLE, ROUTE_PATHS } from '@config';
import { ROUTE_PATHS } from '@config';
import { MEMBERSHIP_CONFIG, MembershipState } from '@features/PurchaseMembership/config';
import { AppState, getMemberships, getMembershipState, membershipExpiryDate } from '@store';
import { BREAK_POINTS, COLORS, FONT_SIZE, SPACING } from '@theme';
Expand Down Expand Up @@ -107,12 +107,6 @@ function MembershipPanel({ memberships, membershipState, expiryDate }: Props) {
<LinkApp href={ROUTE_PATHS.MYC_MEMBERSHIP.path} mt={SPACING.SM}>
{translateRaw('MANAGE_MEMBERSHIP')}
</LinkApp>
<LinkApp
href={getKBHelpArticle(KB_HELP_ARTICLE.MEMBERSHIP_REQUEST_REWARDS)}
isExternal={true}
>
<SButton colorScheme={'inverted'}>{translateRaw('REQUEST_REWARDS')}</SButton>
</LinkApp>
</>
)}
{membershipState === MembershipState.NOTMEMBER && (
Expand Down
1 change: 0 additions & 1 deletion src/translations/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,6 @@
"REQUEST_FORM_TOOLTIP": "Share this QR code with the party who will be fulfilling the payment request. The party will need to scan the QR code with their preferred crypto app. We recommend [Ambo.io!](https://ambo.io/)",
"REQUEST_PAYMENT_CODE": "Payment Code",
"REQUEST_QR_CODE": "QR Code",
"REQUEST_REWARDS": "Request Rewards",
"REQUIRED": "Required",
"RESOURCES": "Resources",
"RISK_REWARD_COLLATERALIZATION": "**Collateralization:** If the crypto price swings, you don’t get liquidated nor does the entire system collapse.",
Expand Down

0 comments on commit eab9fa1

Please sign in to comment.