Add core button variants #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/core-setup
branch
from
d2dcb42
to
eaf007c
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 234 236 +2
Branches 67 69 +2
=========================================
+ Hits 234 236 +2
Continue to review full report at Codecov.
|
Mrtenz
requested changes
Feb 16, 2022
| @@ -7,6 +7,7 @@ import { Spinner } from './Spinner'; | |||
| interface OwnProps { | |||
| compact?: boolean; | |||
| loading?: boolean; | |||
| fullwidth?: boolean; | |||
There was a problem hiding this comment.
Suggested change
| fullwidth?: boolean; | |
| fullWidth?: boolean; |
| fill={get(theme.colors, (fill as keyof Theme['colors']) as string) || fill} | ||
| sx={{ fill: get(theme.colors, (fill as keyof Theme['colors']) as string) || fill }} |
There was a problem hiding this comment.
What's the reason for this?
| @@ -299,6 +305,36 @@ export const theme = { | |||
| } | |||
| } | |||
| }, | |||
| warning: { | |||
There was a problem hiding this comment.
Can you add this to Storybook?
| @@ -299,6 +305,36 @@ export const theme = { | |||
| } | |||
| } | |||
| }, | |||
| warning: { | |||
| cursor: 'pointer', | |||
| background: '', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.