Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decimal places to 0 for VDG token #775

Closed

Conversation

VeriDocGlobaladmin
Copy link
Contributor

Please treat VDG token decimal places to 0 as currently all clients balance displaying in decimal format like
1.5206018374e-8 VDG

Please treat VDG token decimal places to 0 as currently all clients balance displaying in decimal format like
1.5206018374e-8	VDG
@gamalielhere
Copy link
Contributor

@VeriDocGlobaladmin do you have the documentation for the change? or any type of announcement for your users?

Copy link
Contributor

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not doing what the description says

@VeriDocGlobaladmin
Copy link
Contributor Author

Sorry team
But we already add our token as decimal point as 0.
But right now we can check balances are displaying as 18 decimals.
So all our users are confused.
So please update it.
Our all users are aware that we are using 0 as decimals.

@VeriDocGlobaladmin
Copy link
Contributor Author

Hello Team,
Please help me on this.
Please follow below steps to understand my issue.

Please open https://www.myetherwallet.com/
Click on "Send Ether & Tokens"
Select "View w/ Address Only"
Add this address "0xB4d6294Bf0bA461247fe8F49CeFd0B723F3E42e9"
This address have 10 VDG and it display 1e-17 VDG in MEW.
https://ethplorer.io/address/0xb4d6294bf0ba461247fe8f49cefd0b723f3e42e9

Before adding Token in MEW
We are adding VDG as custom Token with below values
Token contract Address: 0x57C75ECCc8557136D32619a191fBCDc88560d711
Token symbol: VDG
Decimals: 0

So at that time it display
10 VDG as balance

@gamalielhere
Copy link
Contributor

@VeriDocGlobaladmin @ligi Looks like this is supposed to be an issue instead of a PR. The changes have been made on the etherwallet repo MyEtherWallet/etherwallet#1994. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants