Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Capitalization of params in keystore files causes issues. #1635

Closed
seigneur opened this issue Feb 25, 2018 · 1 comment · Fixed by #2187
Closed

Capitalization of params in keystore files causes issues. #1635

seigneur opened this issue Feb 25, 2018 · 1 comment · Fixed by #2187

Comments

@seigneur
Copy link

seigneur commented Feb 25, 2018 •
edited
Loading

Issue

When one downloads the keystore file, it has capitalized param Crypto. This should be crypto?

Not sure if this is only for me or across.

screen shot 2018-02-25 at 6 08 39 pm
@seigneur seigneur changed the title Capitalization of params in keystore files causes other modules to break. Capitalization of params in keystore files causes issues. Feb 25, 2018
@gamalielhere
Copy link
Collaborator

Closing this for inactivity.

hackmod added a commit to EthersocialNetwork/etherwallet that referenced this issue Dec 15, 2018
@hackmod
misc fixes
6718ced 
 * fixed keystore mimetype as "application/json"
 * add ".json" extension to blob
 * make "crypto" attribute lowercase (fix MyEtherWallet#1635)
@hackmod hackmod mentioned this issue Dec 15, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc fixes EthersocialNetwork/etherwallet
2 participants
@seigneur @gamalielhere