-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Prepare the 8.5.0 release #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling to understand this. I can't see any changes made since 8.4.0 apart from dependabot. Was 8.4.0 release made from a separate branch? If so, which branch?
I think I see now where the confusion comes from. :sli I created the 8.4.0 release (or better, the 8.4.0 release documentation on GitHub) yesterday because it was missing. Version 8.4.0 had actually been released (i.e., git-tagged, which is what is relevant for Packagist/Composer) on December 11th. You can list the commits since the 8.4.0 tag with this command: git log 8.4.0..HEAD I've done my best to make sense of the commits and compile them into the changelog. (For the future, I'd like us to directly add the changelog entries together with their corresponding PRs.) |
Oh, and the 8.4.0 released was tagged from this repo's default branch, i.e., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 8.4.0 had actually been released (i.e., git-tagged, which is what is relevant for Packagist/Composer) on December 11th.
Ah. I see now.
Oh, and the 8.4.0 released was tagged from this repo's default branch, i.e.,
master
, I think.
I've gone through the commits since 8.4.0 and believe I've found 3 more fixes and one additional feature. I've also found the PR numbers for the items you added to the changelog without one. The other items you added seem correct.
Given there has actually been one new feature since 8.4.0 (#384), should the next release in fact be 8.5.0?
CHANGELOG.md
Outdated
|
||
- Retain CSSList and Rule comments when rendering CSS (#351) | ||
- Replace invalid `turns` unit with `turn` (#350) | ||
- Also allow string values for rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allowing string values for rules had PR number #348.
CHANGELOG.md
Outdated
### Fixed | ||
|
||
- Retain CSSList and Rule comments when rendering CSS (#351) | ||
- Replace invalid `turns` unit with `turn` (#350) | ||
- Also allow string values for rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
Outdated
### Added | ||
|
||
- Add more unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added was #384.
CHANGELOG.md
Outdated
|
||
### Added | ||
|
||
- Add more unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have compiled the changes that seemed relevant from the git history.
8e98b2c
to
6d4c502
Compare
Done and repushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now.
Sorry for delay in re-review - I didn't get any email notification (though did about the original PR, and also received a couple of other GitHub notification emails on the same day).
Auto-deletion of merged branches appears not to be enabled. |
Also, I didn't see the 'Squash-and-Merge' option, 'Merge Branch' was the default, but maybe I should have looked for a dropdown on the button to change it - can't remember now if there was one. |
@JakeQZ @oliverklee thank you both so much! |
I've just tagged and released the new version: https://github.com/sabberworm/PHP-CSS-Parser/releases/tag/8.5.0 |
I have compiled the changes that seemed relevant from the git history.