[TASK] Add visibility to all class/interface constants #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pre-patch to switching to the PER2 coding standard.
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
sabberworm
approved these changes
Feb 13, 2024
oliverklee
added a commit
that referenced
this pull request
Feb 24, 2024
This communicates that the constants must not be accessed from outside the project, thus preventing breakage as most of the constants will have a reduced visibility in version 9 (#470).
oliverklee
added a commit
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-patch to switching to the PER2 coding standard.