Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add PHP 8.4 to the CI matrix #657

Merged
merged 1 commit into from
Aug 25, 2024
Merged

[FEATURE] Add PHP 8.4 to the CI matrix #657

merged 1 commit into from
Aug 25, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee self-assigned this Aug 23, 2024
@oliverklee oliverklee marked this pull request as draft August 23, 2024 09:13
@oliverklee oliverklee marked this pull request as ready for review August 23, 2024 09:15
JakeQZ
JakeQZ approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that composer.json already allows PHP 8.4.

So there is no need to back-port anything for a minor release.

@JakeQZ JakeQZ merged commit 893d204 into main Aug 25, 2024
20 checks passed
@JakeQZ JakeQZ deleted the feature/php-84 branch August 25, 2024 22:38
@oliverklee
Copy link
Contributor Author

So there is no need to back-port anything for a minor release.

I'd still like to backport this for two reasons:

  1. We then at least have PHP 8.4 linting for the maintenance version as well.
  2. We communicate via the changelog that 8.x officially supports PHP 8.4

Would that be okay for you?

@oliverklee oliverklee mentioned this pull request Aug 26, 2024
Merged
@JakeQZ
Copy link
Contributor

JakeQZ commented Aug 26, 2024

I'd still like to backport this for two reasons:

  1. We then at least have PHP 8.4 linting for the maintenance version as well.
  2. We communicate via the changelog that 8.x officially supports PHP 8.4

Would that be okay for you?

Yes. Good points, particularly the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
enhancement to-backport
Projects
None yet
Milestone
8.7.0: Add support for PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ