Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute selector for "disabled" not applied #375

Closed
wants to merge 1 commit into from
Closed

Attribute selector for "disabled" not applied #375

wants to merge 1 commit into from

Conversation

sammuell
Copy link

@sammuell sammuell commented Mar 9, 2017

No description provided.

@oliverklee oliverklee mentioned this pull request Mar 9, 2017
Closed
@oliverklee oliverklee changed the title added test for failing normalize.css rule Attribute selector for "disabled" not applied Mar 9, 2017
@oliverklee oliverklee added the bug label Mar 9, 2017
@oliverklee oliverklee added this to the 1.3.0 milestone Mar 9, 2017
@oliverklee
Copy link
Contributor

We've moved the repository to https://github.com/MyIntervals/emogrifier . If you have an "upstream" branch in your fork, please make sure to update the URL:

git remote set-url upstream git@github.com:MyIntervals/emogrifier.git

@oliverklee oliverklee modified the milestones: 1.3.0, 1.4.0 Oct 21, 2017
@oliverklee oliverklee modified the milestones: 2.1.0, 3.0.0 Apr 3, 2018
@JakeQZ JakeQZ self-assigned this Sep 13, 2019
JakeQZ added a commit that referenced this pull request Sep 13, 2019
@JakeQZ
[TASK] Test descendant attribute selectors
a48742e 
Implemented these tests that were previously commented as “broken”, and added a
test for presence of a Boolean attribute.  They have been fixed by virtue of
using the Symfony CssSelector component.

Resolves #375.
@JakeQZ JakeQZ mentioned this pull request Sep 13, 2019
Merged
oliverklee pushed a commit that referenced this pull request Sep 13, 2019
@JakeQZ @oliverklee
[TASK] Test descendant attribute selectors (#709)
cce60a8 
Implemented these tests that were previously commented as “broken”, and added a
test for presence of a Boolean attribute.  They have been fixed by virtue of
using the Symfony CssSelector component.

Resolves #375.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JakeQZ JakeQZ

Labels
blocked bug unit tests needed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sammuell @oliverklee @JakeQZ