[TASK] Test :only-of-type #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a “broken: …” comment placeholder to indicate that support for `:only-of-type` with the Symfony CssSelector component has been checked and found to be broken (see symfony/symfony#33773), suggesting tests to be added when it is fixed. (It does not make sense to support a feature that is broken the way it is – for email clients that support `:only-of-type`, the desired result will currently only be achieved if rules involving it are copied to a `<style>` element, rather than being only partially inlined.) Added test to confirm rules with `:only-of-type` are copied to a `<style>` element. In the README, added `:only-of-type` to the list of unsupported static pseudo-classes that are copied to a `<style>` element rather than being inlined. Part of #748.
oliverklee
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a “broken: …” comment placeholder to indicate that support for
:only-of-typewith the Symfony CssSelector component has been checked andfound to be broken (see symfony/symfony#33773),
suggesting tests to be added when it is fixed.
(It does not make sense to support a feature that is broken the way it is – for
email clients that support
:only-of-type, the desired result will currentlyonly be achieved if rules involving it are copied to a
<style>element, ratherthan being only partially inlined.)
Added test to confirm rules with
:only-of-typeare copied to a<style>element.
In the README, added
:only-of-typeto the list of unsupported staticpseudo-classes that are copied to a
<style>element rather than being inlined.Part of #748.