Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Make use of PHP 7.0 language features #777

Merged
merged 2 commits into from
Oct 1, 2019
Merged

[CLEANUP] Make use of PHP 7.0 language features #777

merged 2 commits into from
Oct 1, 2019

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 4.0.0 milestone Oct 1, 2019
@oliverklee oliverklee self-assigned this Oct 1, 2019
@oliverklee
Copy link
Contributor Author

Hold on, I think we can enable even more sniffs here. On it.

@oliverklee oliverklee changed the title [CLEANUP] Make use of PHP 7.0 language features [WIP][CLEANUP] Make use of PHP 7.0 language features Oct 1, 2019
@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 1, 2019

Hold on, I think we can enable even more sniffs here. On it.

OK...

@oliverklee oliverklee changed the title [WIP][CLEANUP] Make use of PHP 7.0 language features ][CLEANUP] Make use of PHP 7.0 language features Oct 1, 2019
@oliverklee
Copy link
Contributor Author

Done.

@oliverklee oliverklee changed the title ][CLEANUP] Make use of PHP 7.0 language features [CLEANUP] Make use of PHP 7.0 language features Oct 1, 2019
@oliverklee oliverklee mentioned this pull request Oct 1, 2019
Closed
JakeQZ
JakeQZ reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. I've left a few comments/observations that may or may not suggest further changes...

src/Emogrifier/CssInliner.php Show resolved Hide resolved
src/Emogrifier/CssInliner.php Show resolved Hide resolved
src/Emogrifier/CssInliner.php Outdated Show resolved Hide resolved
src/Emogrifier/HtmlProcessor/AbstractHtmlProcessor.php Show resolved Hide resolved
tests/Unit/CssInlinerTest.php Show resolved Hide resolved
@oliverklee
Copy link
Contributor Author

Updated and repushed.

JakeQZ
JakeQZ approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super.

@JakeQZ JakeQZ merged commit 6b4d03e into master Oct 1, 2019
@JakeQZ JakeQZ deleted the task/php-7.0-changes branch October 1, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ