[TASK] disable php-cs-fixer yoda conditions #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JakeQZ
requested changes
Oct 5, 2019
d'oh |
SignpostMarv
force-pushed
the
do-or-do-not-there-is-no-try
branch
from
dadd1da
to
6a7c688
Compare
|
used the |
That's fine in this case. I think I should be able to uppercase the first character of the CHANGELOG title while you focus on more important work 😎 |
JakeQZ
approved these changes
Oct 5, 2019
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 5, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: MyIntervals#794, MyIntervals#778 (comment)
And now just spotted that pun :) |
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 7, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: MyIntervals#794, MyIntervals#778 (comment)
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 7, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: MyIntervals#794, MyIntervals#778 (comment)
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 7, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: MyIntervals#794, MyIntervals#778 (comment)
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 7, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: * MyIntervals#794 * MyIntervals#778 (comment) * MyIntervals#805 (review)
JakeQZ
pushed a commit
that referenced
this pull request
Oct 7, 2019
… updating baseline. This commit resolves one of the PossiblyNullPropertyAssignmentValue issues identified in src/HtmlProcessor/AbstractHtmlProcessor.php at the expense of identifying various further Null issues regarding: #537 (Note: the following commit messages from the PR are included for completeness, but may overlap with others due to merges/rebases.) * [BUGFIX] partially satisfy psalm, updating baseline This commit resolves the PossiblyNullReference issues introduced by a previous [BUGFIX] in src/HtmlProcessor/AbstractHtmlProcessor.php by refactoring `$this->domDocument->` to `$this->getDomDocument()->` This necessarily alters the body of the previously identified NullableReturnStatement issue. regarding: #537 * [BUGFIX] partially satisfy psalm, updating baseline This commit resolves 1 InvalidNullableReturnType and 1 NullableReturnStatement issue identified in src/HtmlProcessor/AbstractHtmlProcessor.php by throwing an exception if `AbstractHtmlProcessor::$domDocument` has not been set. regarding: #537 * [BUGFIX] satisfy php-cs-fixer This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: * #794 * #778 (comment) * #805 (review) * [TASK] Add exception code based on UNIX timestamp regarding: #805 (comment) * [CLEANUP] Adjust indentation This commit adjusts the indentation separate from the addition of parenthesis in a previous commit, on the basis of making indentation & line break changes separate from functional changes. regarding: #805 (comment)
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this pull request
Oct 7, 2019
This commit resolves the yoda conditions introduced in previous [BUGFIX] commits. regarding: MyIntervals#794, MyIntervals#778 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding: #791, #778 (comment)