Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Move php-cs-fixer to phive #851

Merged
merged 1 commit into from
Mar 28, 2020
Merged

[TASK] Move php-cs-fixer to phive #851

merged 1 commit into from
Mar 28, 2020

Conversation

oliverklee
Copy link
Contributor

This reduces conflicts between our dependencies.

Part of #822

@oliverklee oliverklee added this to the 4.0.0 milestone Mar 28, 2020
@oliverklee oliverklee self-assigned this Mar 28, 2020
This reduces conflicts between our dependencies.

Part of #822
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverklee
Copy link
Contributor Author

Should https://github.com/MyIntervals/emogrifier/blob/master/.github/CONTRIBUTING.md#install-the-development-dependencies also be updated?

Yes, when we move the corresponding tools (i.e., not in this PR).

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should https://github.com/MyIntervals/emogrifier/blob/master/.github/CONTRIBUTING.md#install-the-development-dependencies also be updated?

Yes, when we move the corresponding tools (i.e., not in this PR).

OK

@JakeQZ JakeQZ merged commit f4287e8 into master Mar 28, 2020
@JakeQZ JakeQZ deleted the task/phive-fixer branch March 28, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants