Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Stop checking tests/ with Psalm #885

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Jun 13, 2020

This will pave the way towards moving Psalm to Phive
until we find a better solution.

As the tests call the production code, Psalm would mark the called
code as unused. So we need to disable some checks for unused code.

Fixes #879

@oliverklee oliverklee added this to the 5.0.0 milestone Jun 13, 2020
@oliverklee oliverklee self-assigned this Jun 13, 2020
@oliverklee oliverklee marked this pull request as draft June 13, 2020 10:48
@oliverklee oliverklee changed the title [TASK] Stop checking tests/ with Psalm [WIP][TASK] Stop checking tests/ with Psalm Jun 13, 2020
@oliverklee
Copy link
Contributor Author

This needs more changes for the Psalm configuration.

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And, thinking about it, trying to check the testing code was actually holding us back checking the actual code. In the long run we can reintroduce it, but I'd rather see an almost empty baseline from src/ first.

@oliverklee oliverklee changed the title [WIP][TASK] Stop checking tests/ with Psalm [TASK] Stop checking tests/ with Psalm Jun 14, 2020
@oliverklee oliverklee marked this pull request as ready for review June 14, 2020 08:48
This will pave the way towards moving Psalm to Phive
until we find a better solution.

As the tests call the production code, Psalm would mark the called
code as unused. So we need to disable some checks for unused code.

Fixes #879
@JakeQZ JakeQZ merged commit d013539 into master Jun 14, 2020
@JakeQZ JakeQZ deleted the task/remove-phpunit-psalm branch June 14, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop checking tests/ with Psalm
2 participants