[TASK] Rename the PHPCS configuration file #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two possible file names for the PHP_CodeSniffer configuration file: - `phpcs.xml.dist` - `phpcs.xml` The intention of the first file name is: "This is a template. Please copy it, modify it and then save it under the corresponding file name without the .dist` suffix." As our configuration file is not a template, we now use the non-template variant. As an additional benefit, IDEs usually recognize the `.xml` suffix without any additional configuration.
JakeQZ
approved these changes
Jun 14, 2020
There was a problem hiding this comment.
Ah, I see, this would have been a bit like having wp-config-sample.php as the actual configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two possible file names for the PHP_CodeSniffer configuration
file:
phpcs.xml.distphpcs.xmlThe intention of the first file name is: "This is a template. Please copy
it, modify it and then save it under the corresponding file name without
the .dist` suffix."
As our configuration file is not a template, we now use the non-template
variant.
As an additional benefit, IDEs usually recognize the
.xmlsuffixwithout any additional configuration.