[TASK] Automatically add a backslash for global functions #909
Conversation
There was a problem hiding this comment.
I'm sure I added something to PHPCS (the other one, not the fixer) to catch this, shortly after you added the FQN prefix throughout. Though even a triple safety lock did not prevent the Deepwater Horizon oil spill. So, the more the merrier (to coin a more cheery phrase).
Could you complete the 'edit' part of the 'copy, paste, edit' for the changelog ;))
CHANGELOG.md
Outdated
| - Upgrade to PHPUnit 7.5 | ||
| ([#908](https://github.com/MyIntervals/emogrifier/pull/908)) |
There was a problem hiding this comment.
Forget to edit after copy and paste? ;))
There was a problem hiding this comment.
Good catch. Obviously very much so. :-)
Indeed. (At least we seem to have a working PHPCS rule for this now - I've just checked.) |
Using a leading backslash when calling a function in the global namespace provides a (small) performance benefit. Adjust the PHP CS Fixer configuration to add any missing backslashes.
oliverklee
force-pushed
the
task/global-backslashes
branch
from
0d8753e
to
2cb778a
Compare
|
Fixed the changelog (also the issue number there) and repushed. |
oliverklee
changed the title
oliverklee
changed the title
Using a leading backslash when calling a function in the global namespace
provides a (small) performance benefit.
Adjust the PHP CS Fixer configuration to add any missing backslashes.