Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet urls methods. #1

Merged
merged 11 commits into from
Nov 1, 2022
Merged

Wallet urls methods. #1

merged 11 commits into from
Nov 1, 2022

Conversation

OmarEMC
Copy link

@OmarEMC OmarEMC commented Oct 28, 2022

Motivation

In some cases we want the sign in process not to redirect the whole page, but to be open in a popup window.
As mentioned in near#1010

Description

Added to extra methods (requestSignInLink and requestSignInLink) to the WalletConnection, to get the needed urls to the NEAR wallet.

Checklist

  • Read the contributing guidelines
  • Commit messages follow the conventional commits spec
  • Performed a self-review of the PR
  • Added automated tests (The methods added are already tested as they are executed by the ones with a writed test)
  • Manually tested the change

@DevSlashRichie DevSlashRichie merged commit 30f6fa1 into master Nov 1, 2022
@DevSlashRichie DevSlashRichie deleted the wallet-urls branch November 1, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants