chore: Changed Doctrine Annotation to Attribute #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robvanderlee
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 🌟
This changes the deprecated annotation docblocks to attribute. Used rector to change the blocks and then rearranged the comments there were needed manually.
Technical choices ⚙️
3.x-devbranch due to Doctrine3.xnot being BC.DoctrineSetList::ANNOTATIONS_TO_ATTRIBUTESas-per upgrade guide.Testing instructions 📚
You can test this PR by following these steps:
myparcel-shipment-loggerto test this PR as it's using the attribute driver.